 | Sir John Mills' Moving Memories (2000) as Self (archive footage) |
 | Dors: The Other Diana (1990) |
 | The Massacre of Glencoe (1971) as MacIain |
 | Doctor in Trouble (1970) as Sir Lancelot Spratt |
 | Some Will, Some Won't (1970) as Sir Charles Robson |
 | Zeta One (1969) as Major Bourdon |
 | Chitty Chitty Bang Bang (1968) as Lord Scrumptious |
 | Mayerling (1968) as Prince of Wales |
 | Histoires extraordinaires (1968) as Countess' Advisor (segment "Metzengerstein") |
 | Hell Is Empty (1967) as Angus McGee |
 | À cœur joie (1967) as McClintock |
 | The Trygon Factor (1966) as Sir John (voice) |
 | Lucy in London (1966) as Head of Madame Tussauds' Guides |
 | Lange Beine - lange Finger (1966) as Sir Hammond |
 | Doctor in Clover (1966) as Sir Lancelot Spratt |
 | The Face of Fu Manchu (1965) as Sir Charles |
 | You Must Be Joking (1965) as Librarian |
 | Those Magnificent Men in Their Flying Machines or How I Flew from London to Paris in 25 Hours 11 Minutes (1965) as Narrator |
 | Up from the Beach (1965) as British Beachmaster |
 | Father Came Too! (1964) as Sir Beverley Grant |
 | Dr. Crippen (1963) as Captain McKenzie |
 | Doctor in Distress (1963) as Sir Lancelot Spratt |
 | Das Feuerschiff (1963) as Kapitän Freytag |
 | Mystery Submarine (1963) as RAdm. Rainbird |
 | The Fast Lady (1962) as Commander Charles Chingford |
 | Le Repos du guerrier (1962) as Katov - un sculpteur |
 | Guns of Darkness (1962) as Hugo Bryant |
 | Crooks Anonymous (1962) as Sir Harvey Russellrod |
 | A Pair of Briefs (1962) as Justice Haddon |
 | Murder She Said (1961) as Luther Ackenthorpe |
 | Raising the Wind (1961) as Sir Benjamin Boyd |
 | The Guns of Navarone (1961) as Commodore Jensen / Prologue Narrator |
 | Very Important Person (1961) as Sir Ernest "Lieutenant M.J. Farrow, RN" Pease, KBE, FRS |
 | Die Botschafterin (1960) as Robert Morrison |
 | A French Mistress (1960) as Robert Martin / 'Bow Wow' |
 | Doctor in Love (1960) as Sir Lancelot Spratt |
 | Foxhole in Cairo (1960) as Capt. Robertson |
 | Upstairs and Downstairs (1959) as James Mansfield |
 | Orders to Kill (1958) as Naval Commander |
 | Thérèse Étienne (1958) as Anton Muller |
 | Seven Thunders (1957) as Dr. Martout |
 | Campbell's Kingdom (1957) as 'Mac' MacDonald |
 | The Living Idol (1957) as Doctor Alfred Stoner |
 | Doctor at Large (1957) as Sir Lancelot Spratt |
 | Checkpoint (1956) as Warren Ingram |
 | The Iron Petticoat (1956) as Colonel Vladimir Denisovich Sklarnoff |
 | Moby Dick (1956) as Capt. Boomer |
 | Storm Over the Nile (1955) as General Burroughs |
 | An Alligator Named Daisy (1955) as Sir James Colebrook |
 | Land of the Pharaohs (1955) as Vashtar |
 | Doctor at Sea (1955) as Captain Wentworth Hogg |
 | Above Us the Waves (1955) as Admiral Ryder |
 | Out of the Clouds (1955) as Captain Brent |
 | Doctor in the House (1954) as Sir Lancelot Spratt |
 | Rob Roy, The Highland Rogue (1953) as Duke Campbell, of Argyll |
 | The Sword and the Rose (1953) as King Henry VIII |
 | The Voice of Merrill (1952) as Jonathan Roche |
 | Miss Robin Hood (1952) as The MacAlister |
 | Les Miserables (1952) as Robert |
 | The Story of Robin Hood and His Merrie Men (1952) as Little John |
 | The Lady Says No (1952) as Matthew Huntington Hatch |
 | Anne of the Indies (1951) as Red Dougal |
 | David and Bathsheba (1951) as Abishai |
 | Captain Horatio Hornblower R.N. (1951) as Seaman Quist |
 | Pool of London (1951) as Engine Room Officer Trotter |
 | Blackmailed (1951) as Mr. Sine |
 | The Magnet (1950) as Tramp |
 | The Black Rose (1950) as Simeon Beautrie |
 | My Daughter Joy (1950) as Prof. Keval |
 | Prelude to Fame (1950) as Sir Arthur Harold |
 | Christopher Columbus (1949) as Martin Alonso Pinzon |
 | Private Angelo (1949) as Feste |
 | Poet's Pub (1949) as Prof. Benbow |
 | Whisky Galore! (1949) as Dr. Maclaren |
 | Stop Press Girl (1949) as Arthur Peters |
 | Scott of the Antarctic (1948) as P.O. (Taff) Evans R.N. |
 | Quartet (1948) as Branksome (segment "The Facts of Life") |
 | My Brother Jonathan (1948) as Eugene Dakers |
 | Against the Wind (1948) as Ackerman |
 | Vice Versa (1948) as Dr. Grimstone |
 | Appointment with Crime (1946) as Prison Governor |
 | Fiddlers Three (1944) as Centurion of the 8th Legion |
 | Champagne Charlie (1944) as Patron (uncredited) |
 | For Those in Peril (1944) as Operations Room Officer |
